Skip to content

Conversation

pipiland2612
Copy link
Contributor

@pipiland2612 pipiland2612 commented Aug 16, 2025

Which problem is this PR solving?

Description of the changes

  • Improve the readme file for better comment

How was this change tested?

Screenshot 2025-08-16 at 20 25 53 Screenshot 2025-08-16 at 20 26 06

Checklist

Signed-off-by: pipiland2612 <[email protected]>
Signed-off-by: pipiland2612 <[email protected]>
@pipiland2612 pipiland2612 reopened this Aug 16, 2025
Signed-off-by: pipiland2612 <[email protected]>
@pipiland2612
Copy link
Contributor Author

This is so strange, my change is not even related to e2e test for some functionality, but all the e2e test keeps failing

Copy link

github-actions bot commented Aug 16, 2025

Metrics Comparison Summary

summary_metrics_snapshot_kafka

📊 Metrics Diff Summary

Total Changes: 3

  • 🆕 Added: 0 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 3 metrics

🔄 Modified Metrics

  • otelcol_kafka_exporter_records
    • Added variants: 1
    • Removed variants: 1
  • otelcol_kafka_exporter_messages
    • Added variants: 1
    • Removed variants: 1
  • otelcol_kafka_exporter_bytes_uncompressed_bytes
    • Added variants: 1
    • Removed variants: 1

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

  • 🆕 Added: 53 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics

🆕 Added Metrics

  • http_server_request_body_size_bytes (18 variants)
  • http_server_request_duration_seconds (17 variants)
  • http_server_response_body_size_bytes (18 variants)

summary_metrics_snapshot_elasticsearch

📊 Metrics Diff Summary

Total Changes: 73

  • 🆕 Added: 0 metrics
  • ❌ Removed: 73 metrics
  • 🔄 Modified: 0 metrics

❌ Removed Metrics

  • jaeger_storage_latency_seconds (18 variants)
  • jaeger_storage_requests_total (1 variants)
  • rpc_server_duration_milliseconds (18 variants)
  • rpc_server_requests_per_rpc (18 variants)
  • rpc_server_responses_per_rpc (18 variants)

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

  • 🆕 Added: 53 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics

🆕 Added Metrics

  • http_server_request_body_size_bytes (18 variants)
  • http_server_request_duration_seconds (17 variants)
  • http_server_response_body_size_bytes (18 variants)

➡️ View full metrics file

@pipiland2612 pipiland2612 reopened this Aug 16, 2025
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Aug 16, 2025
@pipiland2612 pipiland2612 reopened this Aug 16, 2025
@pipiland2612 pipiland2612 reopened this Aug 16, 2025
@pipiland2612 pipiland2612 reopened this Aug 16, 2025
@pipiland2612 pipiland2612 reopened this Aug 17, 2025
Copy link

codecov bot commented Aug 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.63%. Comparing base (c1f0f36) to head (b028252).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7449       +/-   ##
===========================================
+ Coverage   33.68%   96.63%   +62.95%     
===========================================
  Files         202      377      +175     
  Lines       12986    23089    +10103     
===========================================
+ Hits         4374    22312    +17938     
+ Misses       8269      592     -7677     
+ Partials      343      185      -158     
Flag Coverage Δ
badger_v1 9.02% <ø> (ø)
badger_v2 1.70% <ø> (ø)
cassandra-4.x-v1-manual 11.68% <ø> (?)
cassandra-4.x-v2-auto 1.69% <ø> (ø)
cassandra-4.x-v2-manual 1.69% <ø> (ø)
cassandra-5.x-v1-manual 11.68% <ø> (?)
cassandra-5.x-v2-auto 1.69% <ø> (ø)
cassandra-5.x-v2-manual 1.69% <ø> (ø)
elasticsearch-6.x-v1 16.58% <ø> (?)
elasticsearch-7.x-v1 16.62% <ø> (?)
elasticsearch-8.x-v1 16.77% <ø> (?)
elasticsearch-8.x-v2 1.70% <ø> (?)
elasticsearch-9.x-v2 1.70% <ø> (?)
grpc_v1 10.22% <ø> (ø)
grpc_v2 1.70% <ø> (ø)
kafka-3.x-v1 9.67% <ø> (ø)
kafka-3.x-v2 1.70% <ø> (?)
memory_v2 1.70% <ø> (ø)
opensearch-1.x-v1 16.67% <ø> (ø)
opensearch-2.x-v1 16.67% <ø> (?)
opensearch-2.x-v2 1.70% <ø> (ø)
opensearch-3.x-v2 1.70% <ø> (?)
query 1.70% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pipiland2612
Copy link
Contributor Author

pipiland2612 commented Aug 17, 2025

Hi @yurishkuro, I don't know why some metrics are changed(may be e2e test is non deterministic at some parts). But this pr should be good now.

@yurishkuro
Copy link
Member

yes we need to fix this. In Kafka e2e tests we use randomized topic names and the topic is added as a label to the metrics, causing the differences. We may need to add some sanitization to the metric dump steps to remove random suffixes in metric labels.

Don't know about cassandra, it's possible it's the same reason, a randomized namespace inserted as labels.

Btw it would be useful to include a sample of diffs, e.g. 5-7 lines, in the report. We can expect the number of diffs to be relatively small across PRs, and it's much easier to see the report directly than to download and unpack the artifacts.

@pipiland2612
Copy link
Contributor Author

pipiland2612 commented Aug 17, 2025

Btw it would be useful to include a sample of diffs, e.g. 5-7 lines, in the report. We can expect the number of diffs to be relatively small across PRs, and it's much easier to see the report directly than to download and unpack the artifacts.

Hi @yurishkuro,
Make sense, I can do it in a separate pull request, thanks for your feedback!

@yurishkuro yurishkuro merged commit bb2c9b6 into jaegertracing:main Aug 17, 2025
336 of 419 checks passed
@pipiland2612 pipiland2612 deleted the improve_metrics_summary branch August 17, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants